Convert repository-* from integTest to [yaml | java]RestTest or internalClusterTest#60085
Conversation
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM. What's the final step for removing integTest altogether?
|
|
||
| task gcsThirdPartyTest(type: Test) { | ||
| dependsOn integTest,largeBlobIntegTest | ||
| SourceSetContainer sourceSets = project.getExtensions().getByType(SourceSetContainer.class); |
There was a problem hiding this comment.
We should think about building up some kind of convenience around this sort of thing.
There was a problem hiding this comment.
Why isn't the yaml-rest-test plugin doing this setup?
There was a problem hiding this comment.
It's not that simple. By default the java plugin wires up all tasks of type Test with the test source set. What happens when we have a project with multiple test source sets, and then we manually create a Test task? Which source set should it default to?
There was a problem hiding this comment.
Ah sorry, I misread this as the main yaml test, but i realize now this is another test task also utilizing the new source set. I agree then a helper or something to do this would be good, as it seems used several times in this PR.
There was a problem hiding this comment.
Agreed , I will take a look (in a future PR) for any way to simplify this boiler plate.
|
@mark-vieira - thanks for the review
I still have x-pack and some qa projects left. Once they are converted I should be able to remove it from all plugins. |
|
@elasticmachine update branch |
…nalClusterTest (elastic#60085) For OSS plugins that being with repository-*, integTest task is now a no-op and all of the tests are now executed via a test, yamlRestTest, javaRestTest, or internalClusterTest. related: elastic#56841 related: elastic#59444
mark-vieira
added
Team:Delivery
4 participants
For OSS plugins that being with
repository-*,integTesttask is now a no-op and all of the tests are now executed via a test,
yamlRestTest,javaRestTest, orinternalClusterTest.related: #56841
related: #59444